Repository navigation
Conversation
sherenkov
force-pushed
the
bug/#1697/compound-application-tests
branch
from
November 12, 2026 00:35
bff0d86 to
b3164d6
Compare
Contributor
Author
|
@yegor256 CI is green and the branch is up to date with |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compound-namechecked the name of every object with a@base. A unit test written as an application, such aspos.eq 6 +> can-find-space, carries one, so it was reported asObject name "+can-find-space" should not be compound unless it's formation, whilebad-test-namerequires every test name to start withcan-,accepts-,cannot-,rejects-orstops-on-. No name of such a test could pass both lints. A[] +> can-find-spaceformation escaped only because it has no@base.The selector in
names/compound-name.xslnow skips unit tests througheo:test-namefromfuncs/test-name.xsl, the waynot-empty-atomdoes since #1681.Two new packs:
allows-unit-tests-written-as-applications.yaml: positive and negative tests written as applications, horizontal and vertical, next to a formation test, give no defect. Without the fix it gets three.catches-compound-attribute-next-to-application-test.yaml: a compound attributespace-posnext to such a test is still reported, and only it. Without the fix the test is reported too.mvn clean test -Dtest='LtByXslTest#checksAllLints'passes locally, and both packs fail without the change.Closes #1697.